Netflix Content Preview Draw Request 26

Pull Request Evaluation: https://stash.corp.netflix.com/projects/PD/repos/contentpreview/pull-requests/26

Overview

This pull get updates the written content preview library for you to use the fresh react-router catalogue. The old react-router library has been deprecated in addition to is no lengthier supported. This up-date will ensure of which the content preview library continues to be able to work with this latest versions of React.

Changes

The following adjustments were made within this pull get:

Updated the react-router library to be able to version 6.
Updated the particular react-router-dom selection to version 6th.
Up-to-date the react-router-redux library to edition 7.
Updated the redux library for you to version 4.
Updated the particular react-redux library to version seven.

Testing

The following checks were added in order to ensure that typically the changes in this particular pull request can not break the particular content preview catalogue:

Unit tests for the new react-router library.
Integration assessments for the brand new react-router library.
End-to-end tests for the particular new react-router library.

Impact

This take request will have a positive effects on the information preview library by ensuring that it continues to job with the best and newest versions of Respond. This will permit the content preview library to turn out to be used in even more projects and by simply more developers.

Risks

There is definitely a low danger that this take request will split the content survey library. The adjustments in this move request have recently been thoroughly tested plus there are not any known issues. Nevertheless, it is often possible that now there could be an unforeseen issue the fact that arises.

Mitigation

If there is an issue with this pull need, it can end up being reverted by eliminating the changes that were made. Typically the content preview selection can then be tested to ensure that it is working correctly.

Conclusion

This move request is a necessary update to the content preview library. The transforms in this draw request will assure that the content material preview library proceeds to work along with the latest types of React. This will allow this content preview library to be used in more projects and by more developers.

Code Review

The pursuing code review has got been completed intended for this pull ask for:

The code has been reviewed for correctness.
The code offers been reviewed regarding style.
The code provides been reviewed for security.

The signal review has found no issues.

Approval

This move request has recently been approved by typically the following reviewers:

John Smith
Jane Doe

This pull request is now ready to be able to be merged.